-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue/3105-react-fixes various improvements #3140
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 10, 2021
cahirodoherty-learningpool
approved these changes
May 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
eleanor-heath
approved these changes
May 10, 2021
@tomgreenfield contingent on your review |
tomgreenfield
approved these changes
Jun 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👁️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first part of #3105
Fixed
props
through to react templates rather thanmodel, view
classes
function inreactHelpers.js
now removes duplicatesimg[loading=eager]
fix now usesReact.createElement
rather than template modifications (which didn't work with class based react components)header.jsx
so that it outputs correctly if no value is specifiedChanged
parials/component.jsx
has becomeheader.jsx
as it can be used for articles, blocks and pages laterAdaptView.isReact
toAdaptView.isJSX
as it's more preciseRemoved
reactHelpers.js
clone
,find
andrender
functions as unnecessaryAdded
image.jsx
to centralise and perform automatic graphic switching throughoutjsx
templatesreactHelpers.js
prefixClasses
function, to aid template class creation wherecomponent
andaccordion
are prepended to__inner
and__widget
isInteractive
fromquestionView.js
for use injsx
templates